prevent import loops

[pdns-pipe-nmc.git] / PowerDns.hs

diff --git a/PowerDns.hs b/PowerDns.hs
index b9c809340fd7160e48ee0ce39eeb0b884572068b..7e2d9cc8d440a5dcdd8adf4708e6b415ab1b76c7 100644 (file)
--- a/PowerDns.hs
+++ b/PowerDns.hs
@@ -5,7 +5,7 @@ module PowerDns ( RRType(..)
                 , pdnsOut
                 ) where
 
-import NmcJson
+import NmcDom
 
 data RRType = RRTypeSRV   | RRTypeA   | RRTypeAAAA | RRTypeCNAME
             | RRTypeDNAME | RRTypeSOA | RRTypeRP   | RRTypeLOC
@@ -71,7 +71,7 @@ pdnsReport err =
 pdnsOut :: Int -> String -> String -> RRType -> Either String NmcDom -> String
 pdnsOut ver id name rrtype edom =
   case edom of
-    Left  err -> pdnsReport err
+    Left  err -> pdnsReport $ err ++ " in a query for " ++ name
     Right dom -> foldr addLine "END\n" $ nmc2pdns name rrtype dom
       where
         addLine (nm, ty, dt) accum =
@@ -93,16 +93,17 @@ nmc2pdns name RRTypeAAAA  dom = mapto name "AAAA" $ domIp6 dom
 nmc2pdns name RRTypeCNAME dom = takejust name "CNAME" $ domAlias dom
 nmc2pdns name RRTypeDNAME dom = takejust name "DNAME" $ domTranslate dom
 nmc2pdns name RRTypeSOA   dom =
-  let
-    email = case domEmail dom of
-      Nothing   -> "hostmaster." ++ name
-      Just addr ->
-        let (aname, adom) = break (== '@') addr
-        in case adom of
-          "" -> aname
-          _  -> aname ++ "." ++ (tail adom)
-  in
-    [(name, "SOA", email ++ " 99999999 10800 3600 604800 86400")]
+  if dom == emptyNmcDom then []
+  else
+    let
+      email = case domEmail dom of
+        Nothing   -> "hostmaster." ++ name
+        Just addr ->
+          let (aname, adom) = break (== '@') addr
+          in case adom of
+            "" -> aname
+            _  -> aname ++ "." ++ (tail adom)
+    in [(name, "SOA", email ++ " 99999999 10800 3600 604800 86400")]
 nmc2pdns name RRTypeRP    dom = [] --FIXME
 nmc2pdns name RRTypeLOC   dom = takejust name "LOC" $ domLoc dom
 nmc2pdns name RRTypeNS    dom = mapto name "NS" $ domNs dom