cleanup and document config file a bit

[loctrkd.git] / gps303 / lookaside.py

diff --git a/gps303/lookaside.py b/gps303/lookaside.py
index 93103a64b4d4eb1da61df72414c08f4b35c5bc33..b42ce06f378a5ae10fe9a642475556ab577d6859 100644 (file)
--- a/gps303/lookaside.py
+++ b/gps303/lookaside.py
@@ -2,23 +2,27 @@
 
 from datetime import datetime, timezone
 from logging import getLogger
+from os import umask
 from struct import pack
 import zmq
 
 from . import common
-from .gps303proto import parse_message, proto_by_name, WIFI_POSITIONING
+from .gps303proto import parse_message, WIFI_POSITIONING
 from .opencellid import qry_cell
-from .zmsg import Bcast, Resp
+from .zmsg import Bcast, Resp, topic
 
 log = getLogger("gps303/lookaside")
 
 
 def runserver(conf):
+    if conf.get("lookaside", "backend") != "opencellid":
+        raise NotImplementedError(
+            "Lookaside only implements opencellid backend"
+        )
     zctx = zmq.Context()
     zsub = zctx.socket(zmq.SUB)
     zsub.connect(conf.get("collector", "publishurl"))
-    topic = pack("B", proto_by_name("WIFI_POSITIONING"))
-    zsub.setsockopt(zmq.SUBSCRIBE, topic)
+    zsub.setsockopt(zmq.SUBSCRIBE, topic(WIFI_POSITIONING.PROTO))
     zpush = zctx.socket(zmq.PUSH)
     zpush.connect(conf.get("collector", "listenurl"))
 
@@ -33,21 +37,14 @@ def runserver(conf):
                 datetime.fromtimestamp(zmsg.when).astimezone(tz=timezone.utc),
                 msg,
             )
-            if not isinstance(msg, WIFI_POSITIONING):
-                log.error(
-                    "IMEI %s from %s at %s: %s",
-                    zmsg.imei,
-                    zmsg.peeraddr,
-                    datetime.fromtimestamp(zmsg.when).astimezone(
-                        tz=timezone.utc
-                    ),
-                    msg,
-                )
-                continue
             lat, lon = qry_cell(
                 conf["opencellid"]["dbfn"], msg.mcc, msg.gsm_cells
             )
-            resp = Resp(imei=zmsg.imei, packet=msg.Out(lat=lat, lon=lon).packed)
+            resp = Resp(
+                imei=zmsg.imei,
+                when=zmsg.when,  # not the current time, but the original!
+                packet=msg.Out(latitude=lat, longitude=lon).packed,
+            )
             log.debug("Response for lat=%s, lon=%s: %s", lat, lon, resp)
             zpush.send(resp.packed)